Update fmt after getting a better fix from author #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyweiss
approved these changes
Mar 27, 2021
There was a problem hiding this comment.
Thanks @white238
Please also add a note to RELEASE-NOTES indicating which commit we're now using.
And remove your patch (if applicable).
|
The patch is already gone. RELEASE-NOTES coming... I'm waiting for the fix to get merged before I merge this. |
|
It was just merged, this is good to go |
cyrush
approved these changes
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fmtlib/fmt#2190
Updates fmt to newest master branch. This includes the alternate fix for the compiler bug we ran into with nvcc+xlc from the author.